dunwright/django-blocknote
3
0
Fork 0
Code Issues 6 Pull requests Projects Releases Packages Wiki Activity Actions

fix(menu): Fix menu min-height and recalc max-height #71 #72

Merged
rsevs3 merged 2 commits from issue-71 into main 2025-10-14 03:59:40 +00:00
Conversation 1 Commits 2 Files changed 7 +74 -4
rsevs3 commented 2025-10-14 03:56:43 +00:00 (Migrated from github.com)
Copy link

Reduced the min-height to correctly position menu when only a couple of items. Also got the wrapper container to recalc the max height so that the menu is correctly positioned when going from a large menu to a small menu

  • Override BlockNote's hardcoded 300px min-height with 120px for better UX
  • Add synchronous resize detection when transitioning from submenu back to main menu
  • Implement dual-strategy resize triggers (immediate + async fallback) to eliminate visual flicker
  • Add smooth CSS transitions for height changes during menu resizing

closes #71

Reduced the min-height to correctly position menu when only a couple of items. Also got the wrapper container to recalc the max height so that the menu is correctly positioned when going from a large menu to a small menu - Override BlockNote's hardcoded 300px min-height with 120px for better UX - Add synchronous resize detection when transitioning from submenu back to main menu - Implement dual-strategy resize triggers (immediate + async fallback) to eliminate visual flicker - Add smooth CSS transitions for height changes during menu resizing closes #71
github-actions[bot] commented 2025-10-14 03:58:03 +00:00 (Migrated from github.com)
Copy link

Code Coverage Report

Code Coverage

Summary

  • Overall Coverage: 2.6%
  • Minimum Required: 0%
  • Status: ✅ PASSED

Report generated on 2025-10-14 03:58:03 UTC

Package Details

Package Coverage
django_blocknote 🟢 8.9%
django_blocknote.forms 🟢 0.0%
django_blocknote.image 🟢 0.0%
django_blocknote.models 🟢 0.0%
django_blocknote.templatetags 🟢 0.0%
django_blocknote.views 🟢 0.0%
# Code Coverage Report ![Code Coverage](https://img.shields.io/badge/coverage-2.6%25-red) ## Summary - **Overall Coverage**: 2.6% - **Minimum Required**: 0% - **Status**: ✅ PASSED *Report generated on 2025-10-14 03:58:03 UTC* ## Package Details | Package | Coverage | |---------|-----------| | django_blocknote | 🟢 8.9% | | django_blocknote.forms | 🟢 0.0% | | django_blocknote.image | 🟢 0.0% | | django_blocknote.models | 🟢 0.0% | | django_blocknote.templatetags | 🟢 0.0% | | django_blocknote.views | 🟢 0.0% |
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
chore
A job to be done

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
refactor
Code cleanup

  
tests
Add/Udate tests

  
wontfix
This will not be worked on

No labels
bug
chore
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
refactor
tests
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dunwright/django-blocknote!72
No description provided.